-
aathanOPENUpdated 1 month agoRUST_LOG and RUST_LOG_STYLE support
Component
Forge
Describe the feature you would like
RUST_LOG_STYLE=never seems to have no effect on forge, making it difficult to post logs without ansi codes. RUST_LOG=trace seems to have no effect on cast.
Additional context
No response
7 commont
-
onbjergUpdated 1 month ago
There are no traces in Cast, I think. As for
RUST_LOG_STYLE, I'm not sure why it doesn't work but it should -
aathanUpdated 1 month ago
I had TERM=text and a couple of others trying to remember what terminfo name has no color, but I see in that link that "dumb" should work. Strangely, setting TERM=dumb also has no effect on colorization.
-
mattsseUpdated 1 month ago
There are no traces in Cast, I think. As for
RUST_LOG_STYLE, I'm not sure why it doesn't work but it shouldthis is env_logger but we log via https://github.com/tokio-rs/tracing and I'm not sure if their env filter supports that
-
onbjergUpdated 1 month ago
Right, so we should likely use https://docs.rs/tracing-subscriber/latest/tracing_subscriber/fmt/struct.Layer.html#method.set_ansi - perhaps we can tie that in with some general color detection util that checks
COLOR/terminfo etc? -
aathanUpdated 1 month ago
Hey, just adding this here since it's a nit in the logging crate. If when you look at logging in general maybe you can emit a better error that at least mentions the RUST_LOG variable (or that the error is in regards to logging).
$ export RUST_LOG= $ forge --version ignoring ``: invalid filter directive forge 0.2.0 (64087b5 2022-04-13T00:10:42.429318924+00:00) -
onbjergUpdated 1 month ago
That error is from the logging crate itself, so it's not something we can fix here :/
-
aathanUpdated 1 month ago
Fair enough, but since you are using the package, you could avoid this weird edge case by doing: "if(env(RUST_LOG)=="")deleteEnv("RUST_LOG");"
Happy to submit an issue to them but I'm not a RUST coder and don't know where to find crate projects etc. Point me?
